boards: st nucleo c071rb fix LED, Button, SPI configuration #93351
Conversation
zephyrbot
requested review from
djiatsaf-st,
erwango,
etienne-lms,
FRASTM,
gautierg-st,
GeorgeCGV,
marwaiehm-st and
mathieuchopstm
| @@ -135,8 +135,9 @@ | |||
| }; | |||
|
|
|||
| &spi1 { | |||
| pinctrl-0 = <&spi1_nss_pb0 &spi1_sck_pb3 | |||
| &spi1_miso_pb4 &spi1_mosi_pb5>; | |||
| /* Note: PA5 is shared with green led0 */ | |||
There was a problem hiding this comment.
The test will fail when the SCK pin is connected to PA5 because it shares the pin with led0.
Besides PA6 and PA7 are also shared with I2C2 node.
I suggest keeping the current configuration and update documentation
There was a problem hiding this comment.
Oh thanks, I overlooked the i2c2, as I didn't add that to the nucleo_c091rc.
But I still think the SPI should be mapped to the arduino header, otherwise no arduino uno shield can be used with SPI(w/o manually wiring it up, which is not really practicalbe).
What do you think about the current proposal of moving the I2C2 to the morpho header. As such shields with SPI can be used as long as the button is not used at the same time?
There was a problem hiding this comment.
Okay I understand you thoughts ,
To align with your proposal, i suggest you please to create a new commits with the following changes :
-
SPI :
add this line
pinctrl-0 = <&spi1_nss_pb0 &spi1_sck_pb3 &spi1_miso_pb4 &spi1_mosi_pb5>;
before -
I2C
add this linepinctrl-0 = <&i2c2_scl_pa7 &i2c2_sda_pa6>;before
These changes will help avoid regressions in the related tests.
- The user button does not have a dedicated pull-up resistor on the board, therefore activate the internal pull-up. - The pin for LD2 does not switch the via a transistor, but directly sinks the current of the LED, therefore we need to set it active low. Signed-off-by: Thomas Stranger <thomas.stranger@outlook.com>
This commit changes the spi1 pins to pa15, pa5, pa6, pa7. The SPI instance has been declared as arduino_spi, but different pins have been used. As I2C2 was also using the pins pa6, pa7, I2C2 is remapped to pb13, pb14 - two pins next to each other on the st morpho connector CN10. Signed-off-by: Thomas Stranger <thomas.stranger@outlook.com>
str4t0m
force-pushed
the
st_nucleo_c071rb_fixes
branch
from
464a26e to
47a220e
Compare
|
Working with the
nucleo_c092rcI noticed a few issues in thenucleo_c071rbboard configuration that I propose to fix in this PR:I don't have a
nucleo_c071rbto verify these changes, but tested it on a board that is basically only a different assembly option.